fix(opencode): bound compaction request payload#29860
Open
timrichardson wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29857
Type of change
What does this PR do?
Prevents
/compactfrom creating a summarization request that is larger than the selected model's usable context budget.The compaction path now:
toolOutputMaxChars: 0as a real truncation limitThis fixes large restored sessions where the compaction request itself could overflow before a summary was produced.
How did you verify your code works?
bun test test/session/message-v2.test.tsbun test test/session/compaction.test.tsbun run typecheckI also verified the anonymized fixture from #29857 locally:
788327estimated tokens, overflows308291estimated tokens, compacts successfullyScreenshots / recordings
N/A
Checklist