Remove makeRuntime facade for Permission.Service from llm.ts#22522
Closed
kitlangton wants to merge 1 commit intodevfrom
Closed
Remove makeRuntime facade for Permission.Service from llm.ts#22522kitlangton wants to merge 1 commit intodevfrom
kitlangton wants to merge 1 commit intodevfrom
Conversation
Yield Permission.Service directly from the LLM layer context instead of creating a separate ManagedRuntime via makeRuntime. The approvalHandler callback now uses Effect.runPromise(perm.ask(...)) on the captured implementation, avoiding the extra runtime and its duplicated memoMap.
kitlangton
force-pushed
the
kit/llm-facade-cleanup
branch
from
9fb66c2 to
d57adec
Compare
Contributor
Author
|
Closing — these changes were superseded by #22504 which landed on dev. That PR removes the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
makeRuntime(Permission.Service, Permission.defaultLayer)facade fromsrc/session/llm.tsPermission.Servicedirectly from the LLM layer's Effect context insteadperms.runPromise((svc) => svc.ask(...))withEffect.runPromise(perm.ask(...))in the workflow approval handlerPermission.defaultLayertoLLM.defaultLayerprovidersThis eliminates a separate
ManagedRuntimeinstance that was duplicating the sharedmemoMaplayer deduplication, and aligns the LLM module with the pattern of resolving services through the layer graph.