refactor(permission): remove async facade exports#22342
Merged
kitlangton merged 4 commits intodevfrom Apr 13, 2026
Merged
Conversation
kitlangton
force-pushed
the
facade/permission
branch
from
fe06dc9 to
76c43d1
Compare
mrsimpson
pushed a commit
to mrsimpson/opencode
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppRuntime.runPromise(...)and remove the service-local async permission facade exportssession/llm.tsto callPermission.ServicethroughAppRuntimetest/permission/next.test.tsaway fromPermission.ask/reply/list/runPromisefacade calls to direct service-layer effectsValidation
bun run test test/permission/next.test.ts(fails before loading tests: Bun preload@opentui/solid/preloadis missing in this worktree environment)bun typecheck(currently fails broadly in this worktree due existing dependency/typecheck issues unrelated to this diff, including missing modules likedrizzle-kitand@opentui/solid/bun-plugin)