fix(opencode): handle non-object JSON in parseManagedPlist#22319
Open
shafdev wants to merge 2 commits intoanomalyco:devfrom
Open
fix(opencode): handle non-object JSON in parseManagedPlist#22319shafdev wants to merge 2 commits intoanomalyco:devfrom
shafdev wants to merge 2 commits intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #22318
Type of change
What does this PR do?
parseManagedPlistcallsObject.keys()directly on the result ofJSON.parse()without checking the type first. If an MDM profile is malformed and producesnull, this throwsTypeError: null is not an object. Arrays and primitives also cause unexpected errors.Added a type guard before the loop to return
{}early for anything that isn't a plain object.How did you verify your code works?
Reproduced the crash before the fix:
After the fix, all non-object inputs return
{}without throwing. Added 3 tests coveringnull, array, and number inputs — all pass.Screenshots / recordings
N/A
Checklist