Skip to content

fix: add support for ACP writeTextFile clientCapability#22290

Closed
aprogramq wants to merge 1 commit intoanomalyco:devfrom
aprogramq:dev
Closed

fix: add support for ACP writeTextFile clientCapability#22290
aprogramq wants to merge 1 commit intoanomalyco:devfrom
aprogramq:dev

Conversation

@aprogramq
Copy link
Copy Markdown

@aprogramq aprogramq commented Apr 13, 2026

Issue for this PR

Fixes #4240

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

This fixes ACP file syncing for clients that advertise the fs.writeTextFile capability.
The change stores clientCapabilities during ACP initialization, includes sessionID in file.edited events, and on file edits sends the updated file contents back to the ACP client through writeTextFile.

The SDK/OpenAPI types were updated as part of the event shape change.

How did you verify your code works?

Zed editor

2026-04-13-152258_hyprshot

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

I'm reopening this pull request 6902, as it was closed due to the time limit expiring. The issue is still relevant.

@github-actions github-actions bot added needs:compliance This means the issue will auto-close after 2 hours. needs:title labels Apr 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Hey! Your PR title [REOPEN] fix: add support for ACP writeTextFile clientCapability doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@aprogramq aprogramq changed the title [REOPEN] fix: add support for ACP writeTextFile clientCapability fix: add support for ACP writeTextFile clientCapability Apr 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions github-actions bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Apr 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

acp, zed: does not support native changes review

1 participant