fix(opencode): fix the read tool reports image/pdf read successfully when the LLM lacks vision capabilities#22263
Open
Demonese wants to merge 3 commits intoanomalyco:devfrom
Open
fix(opencode): fix the read tool reports image/pdf read successfully when the LLM lacks vision capabilities#22263Demonese wants to merge 3 commits intoanomalyco:devfrom
Demonese wants to merge 3 commits intoanomalyco:devfrom
Conversation
…when the LLM lacks vision capabilities
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR that should be reviewed: Related PR:
The other results (#21917, #11333, #15262) are related to PDF/image handling but appear to be older or more specific fixes that may not directly conflict with the current PR. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
…when the LLM lacks vision capabilities (Effect.fail)
…when the LLM lacks vision capabilities (update error message)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21800
Type of change
What does this PR do?
The description of the
readtool can mislead text-only LLMs, causing them to hallucinate that they can understand image content.To fix this issue, I first inspected the source code of the
readtool and found that it does not verify the LLM vision capabilities when handling images and PDF files.So fixed it.
How did you verify your code works?
See Screenshots / recordings
Screenshots / recordings
Checklist