fix(opencode): extract nested error message from API responses#22239
Closed
Ricardo-M-L wants to merge 1 commit intoanomalyco:devfrom
Closed
fix(opencode): extract nested error message from API responses#22239Ricardo-M-L wants to merge 1 commit intoanomalyco:devfrom
Ricardo-M-L wants to merge 1 commit intoanomalyco:devfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
denounce |
mrsimpson
pushed a commit
to mrsimpson/opencode
that referenced
this pull request
Apr 14, 2026
Author
|
Understood, closing this PR. Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #22238
Type of change
What does this PR do?
Line 68 in
error.tsusesbody.message || body.error || body.error?.messageto extract error messages from API responses. Whenbody.erroris an object (standard OpenAI/Anthropic format like{ error: { message: "rate limit exceeded" } }), the||short-circuits on the truthy object and never reachesbody.error?.message. Thetypeof errMsg === "string"check on line 69 then rejects the object, so no useful message is shown.Fix: check
typeof body.error === "string"before using it directly, otherwise fall through tobody.error?.message.How did you verify your code works?
Tested with mock API responses in both formats:
{ error: "string error" }→ correctly returns "string error"{ error: { message: "rate limit exceeded" } }→ correctly returns "rate limit exceeded"{ message: "direct message" }→ still works as beforeChecklist