Merged
Conversation
Solid's transition fix now covers the undefined memo bug, so restore the pre-workaround message part bindings and control flow.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the temporary Solid transition workaround logic in message-part rendering and restores the simpler render flow now that the Solid “memo undefined under transition” fix is available in dev.
Changes:
- Remove the
bindMessage(...)snapshotting/undefined-guard workaround and the associatedunwrapusage. - Refactor
AssistantParts,AssistantMessageDisplay, andMessagerendering back to a more directSwitch/Match-based flow. - Keep the existing route/e2e/session cleanup behavior intact while simplifying message/part rendering.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
demostanis
pushed a commit
to demostanis/opencode
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
message-partundefined guards and fallback message snapshotting that were added as a Solid transition workarounddevincludes the Solid memo undefined patch from patch solid to try fix memo undefined under transition bug #18338Testing