Skip to content

deslopity deslopity#18343

Merged
Hona merged 2 commits intoanomalyco:devfrom
Hona:chore/cleanup-slop
Mar 20, 2026
Merged

deslopity deslopity#18343
Hona merged 2 commits intoanomalyco:devfrom
Hona:chore/cleanup-slop

Conversation

@Hona
Copy link
Member

@Hona Hona commented Mar 20, 2026

Summary

Testing

  • bun typecheck (packages/ui)
  • bun typecheck (packages/app)
  • bun test:e2e:local -- e2e/projects/workspace-new-session.spec.ts e2e/projects/projects-switch.spec.ts e2e/session/session-model-persistence.spec.ts

Solid's transition fix now covers the undefined memo bug, so restore the pre-workaround message part bindings and control flow.
Copilot AI review requested due to automatic review settings March 20, 2026 05:13
@Hona Hona enabled auto-merge (squash) March 20, 2026 05:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the temporary Solid transition workaround logic in message-part rendering and restores the simpler render flow now that the Solid “memo undefined under transition” fix is available in dev.

Changes:

  • Remove the bindMessage(...) snapshotting/undefined-guard workaround and the associated unwrap usage.
  • Refactor AssistantParts, AssistantMessageDisplay, and Message rendering back to a more direct Switch/Match-based flow.
  • Keep the existing route/e2e/session cleanup behavior intact while simplifying message/part rendering.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Hona Hona merged commit 0bbf26a into anomalyco:dev Mar 20, 2026
9 checks passed
demostanis pushed a commit to demostanis/opencode that referenced this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants