fix(opencode): prevent literal nul file creation on posix#15183
Open
cyberprophet wants to merge 3 commits intoanomalyco:devfrom
Open
fix(opencode): prevent literal nul file creation on posix#15183cyberprophet wants to merge 3 commits intoanomalyco:devfrom
cyberprophet wants to merge 3 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Author
|
Updated the PR description to match the required template and kept the issue linkage (). Please re-check compliance constraints. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
Updated the PR description to match the required template and kept the issue linkage (Closes #11403). Please re-check compliance constraints. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #11403
Type of change
What does this PR do?
This fixes repeated creation of a literal
nulfile in project directories during shell tool usage.Changes made:
nul/NULto/dev/nullon non-Windows platformsbashtool and session shell runner)stdinfromignoretopipeand explicitly closed it to avoid null-device handling side effectsWhy this works:
nulis a normal filename, not a device; rewriting redirections prevents accidental file creationignorebehaviorHow did you verify your code works?
packages/opencode/test/util/redirection.test.tstypecheckand unit tests passing on linux/windowsglob,tsgo,@opentui/solid/preload), noted transparently in prior descriptionScreenshots / recordings
N/A (non-UI change)
Checklist