-
Notifications
You must be signed in to change notification settings - Fork 30
Link to the Manual #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[A PR that proposes moving/removing 6 unrelated pages is hard to review. In the future, please follow the principle of Do One Thing.] There's more work that needs to be done on this PR before we can review it.
|
Do you think I should make multiple PRs one for each page? I'd like to get dae's opinion on this. Now addressing the other points:
To quote dae:
I think dae decided that we don't keep FAQs here but I see you think otherwise. I'll let dae make the call. FYI the pages I emptied out in this PR all had their info migrated to manual as part of the above linked issue. I just forgot to make the additional changes in FAQs which is what I'm doing here.
Also, I removed the old method of customising Mjax in manual.
|
|
Re do-one-thing, I try to be pragmatic here, as I know atomic commits are more work. But the more you pack into a PR, the more likely is to stall due to an issue with one part, or the time required to review it, so I'd recommend limiting yourself to a few pages at a time in the future. When I wrote ankitects/anki-manual#275, I wasn't aware of the redirect trick Danika discovered - would definitely recommend using that. For 3, as long as existing links don't break, the loss of the TOC entries doesn't worry me too much - I don't think many people are reading through the list when they have issues. If you and Danika are satisfied we haven't lost anything important in 2, LGTM. |
I have mentioned this one before (ankitects/anki-manual#386 (comment)) but it can only be used within the same book so not very useful here. Or there's some trick I'm not aware of? |
|
If I've misattributed the original person to mention this, my apologies. But the docs say that any http(s) link can be used as the target, so we should be able to link to a different book? |
|
Ah, sorry, didn't notice that. So, we should do that instead of emptying the page?
|
|
Saves the user and extra click/read, so it seems preferable to almost-blank 'see here instead' pages. |
|
@brishtibheja
There is still quite a bit being stricken here that has not been added anywhere else. If it's not worth it to you to review each of these more carefully and account for what you're proposing to delete, then it's not worth it for Damien or I to do that for you. And I don't understand the relevance of that link to PR 306. That also didn't add anything to the manual that you're deleting here.
|
Some of the pages here have already been moved. So, I'm emptying them out and linking to the manual.