-
Notifications
You must be signed in to change notification settings - Fork 406
Adding net10.0 to the list of target frameworks #1640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,16 +23,14 @@ | |
| <VersionNoSuffix>$([System.Text.RegularExpressions.Regex]::Match($(Version), '^[0-9.]+')).0</VersionNoSuffix> | ||
| <AssemblyVersion>6.0.0.0</AssemblyVersion> <!-- Fixed to major version, for strong naming --> | ||
| <FileVersion>$(VersionNoSuffix)</FileVersion> <!-- Match the NuGet version number, except any suffix in the semantic version. --> | ||
| <LangVersion>preview</LangVersion> | ||
| <LangVersion>latest</LangVersion> | ||
| <Nullable>enable</Nullable> | ||
| <RootNamespace>UnitsNet</RootNamespace> | ||
| <TargetFrameworks>netstandard2.0;net8.0;net9.0</TargetFrameworks> | ||
| <TargetFrameworks>netstandard2.0;net8.0;net9.0;net10.0</TargetFrameworks> | ||
|
|
||
| <!-- TEMPORARY WORKAROUND UNTIL NET10 SDK IS STABLE | ||
| Disable ILLink analyzers due to incompatibility with C# 14 extension members preview | ||
| <!-- Disable ILLink analyzers due to incompatibility with C# 14 extension members preview | ||
| "CSC : error AD0001: Analyzer 'ILLink.RoslynAnalyzer.DynamicallyAccessedMembersAnalyzer' threw an exception of type 'System.InvalidCastException' with message 'Unable to cast object of type 'Microsoft.CodeAnalysis.CSharp.Symbols.PublicModel.NonErrorNamedTypeSymbol' to type 'Microsoft.CodeAnalysis.IMethodSymbol'.'." --> | ||
| <IsAotCompatible>false</IsAotCompatible> | ||
| <!-- <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">true</IsAotCompatible> --> | ||
| <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net10.0'))">true</IsAotCompatible> | ||
|
Comment on lines
+31
to
+33
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just realized that the persistence of this |
||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, the local build doesn't throw any errors (when running the script as administrator) but I haven't tested if the resulting code is any different (normally it shouldn't, as we haven't changed anything about the nano-project itself).