fix: update document APIs to be readonly#26
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Mar 13, 2026
Merged
Conversation
By spec, these APIs are `readonly`, but do not error when mutated, they just have no effect. APIs affected: * [`Attr.prototype.localName`](https://developer.mozilla.org/en-US/docs/Web/API/Attr/localName) * [`Attr.prototype.prefix`](https://developer.mozilla.org/en-US/docs/Web/API/Attr/prefix) * [`Element.prototype.localName`](https://developer.mozilla.org/en-US/docs/Web/API/Element/localName) * [`Element.prototype.prefix`](https://developer.mozilla.org/en-US/docs/Web/API/Element/prefix) * [`DocumentType.prototype.name`](https://developer.mozilla.org/en-US/docs/Web/API/DocumentType/name) * [`ProcessingInstruction.prototype.target`](https://developer.mozilla.org/en-US/docs/Web/API/ProcessingInstruction/target) This helps prevent malicious data from sneaking into these attributes after construction.
AndrewKushnir
approved these changes
Mar 13, 2026
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
Looks great, thanks @dgp1130 👍
alan-agius4
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By spec, these APIs are
readonly, but do not error when mutated, they just have no effect. APIs affected:Attr.prototype.localNameAttr.prototype.prefixElement.prototype.localNameElement.prototype.prefixDocumentType.prototype.nameProcessingInstruction.prototype.targetThis helps prevent malicious data from sneaking into these attributes after construction.
Alternative solution to: #23
/cc @securityMB