fix(ng-dev/release): improve lockfile exclusion logic in snapshot publishing#3568
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Mar 24, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to improve the lockfile exclusion logic for snapshot publishing by adding support for pnpm-lock.yaml and making the pathspecs more robust.
My review identified two main issues:
- The removal of
package-lock.jsonfrom the exclusion list, which could be a regression for npm-based projects. I've suggested adding it back, along withyarn.lock, for broader package manager support. - A critical issue where pathspecs are wrapped in single quotes. Because the git command is executed without a shell, these quotes will be passed literally, causing the exclusion logic to fail. I've provided a suggestion to remove them.
Addressing these points will ensure the snapshot publishing logic is both more robust and correct across different project setups.
…lishing Update the snapshot publishing logic to more robustly exclude lockfiles from determining if a snapshot is affected by changes. Specifically: - Added pnpm-lock.yaml to the list of excluded paths. - Added both root-level and glob variants for MODULE.bazel.lock, pnpm-lock.yaml, and pubspec.lock.
alan-agius4
force-pushed
the
snapshot-publish-changed-only
branch
from
48beea0 to
cb6af3a
Compare
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the snapshot publishing logic to more robustly exclude lockfiles from determining if a snapshot is affected by changes.
Specifically: