ci: run renovate post-upgrade tasks only for npm and lockfile maintenance#3567
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Mar 24, 2026
Merged
ci: run renovate post-upgrade tasks only for npm and lockfile maintenance#3567alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4 merged 1 commit intoangular:mainfrom
Conversation
…ance Update the Renovate configuration to only trigger post-upgrade commands (pnpm install, sync-all-modules.sh, and update-generated-files) when the npm manager is used or during lock-file maintenance. This ensures that Bazel manager updates not impacting the NPM lock-file or sync-module-bazel will not trigger those tasks.
angular-robot
bot
added
the
area: build & ci
devversion
approved these changes
Mar 24, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Renovate configuration to run post-upgrade tasks only for npm manager updates and lock file maintenance. The implementation correctly uses two separate rules to achieve the desired OR logic. However, this introduces duplication of the postUpgradeTasks block. While functionally correct, this could be improved for better maintainability by extracting the duplicated configuration into a shared preset. My review includes a suggestion on how to address this.
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Renovate configuration to only trigger post-upgrade commands (pnpm install, sync-all-modules.sh, and update-generated-files) when the npm manager is used or during lock-file maintenance. This ensures that Bazel manager updates not impacting the NPM lock-file or sync-module-bazel will not trigger those tasks.