fix(core): use mutable ResponseInit type for RESPONSE_INIT token#66126
Merged
AndrewKushnir merged 1 commit intoangular:mainfrom Dec 17, 2025
Merged
fix(core): use mutable ResponseInit type for RESPONSE_INIT token#66126AndrewKushnir merged 1 commit intoangular:mainfrom
AndrewKushnir merged 1 commit intoangular:mainfrom
Conversation
The `RESPONSE_INIT` token previously used `ResponseInit`. However, `@types/node` (and `undici`) definitions for `ResponseInit` mark properties as `readonly`, which differs from the standard DOM `ResponseInit`. This commit introduces a `ResponseInit` type that explicitly removes `readonly` modifiers to ensure compatibility and allow for mutable options. This type is now used by the `RESPONSE_INIT` token and is exported from `@angular/core`.
alan-agius4
added
action: review
JeanMeche
approved these changes
Dec 17, 2025
JeanMeche
approved these changes
Dec 17, 2025
Member
JeanMeche
left a comment
JeanMeche
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
I think this is fine for a fix as we're not changing the shape of the object.
alan-agius4
added
action: merge
Contributor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RESPONSE_INITtoken previously usedResponseInit. However,@types/node(andundici) definitions forResponseInitmark properties asreadonly, which differs from the standard DOMResponseInit.This commit introduces a
ResponseInittype that explicitly removesreadonlymodifiers to ensure compatibility and allow for mutable options. This type is now used by theRESPONSE_INITtoken and is exported from@angular/core.Example: angular/angular-cli#32147