fix(@angular/build): ignore virtual esbuild paths with (disabled):#33205
Merged
Conversation
Virtual files generated by esbuild for disabled browser fields leak into the watch list, causing spurious rebuilds in watch mode. Previously, only paths where the suffix was a Node.js builtin module were ignored. Now, any path containing `(disabled):` is ignored as it represents a virtual file that doesn't exist on disk. Fixes angular#33160
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the isInternalBundlerFile logic in bundler-context.ts by treating any path containing the (disabled): prefix as a virtual esbuild entry. This change allows for the removal of the builtinModules import from node:module and cleans up unused imports from esbuild. I have no feedback to provide as there were no review comments.
clydin
added
the
action: review
alan-agius4
approved these changes
May 14, 2026
alan-agius4
added
action: merge
Member
Author
|
I'm happy for the fix, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Virtual files generated by esbuild for disabled browser fields leak into the watch list, causing spurious rebuilds in watch mode.
Previously, only paths where the suffix was a Node.js builtin module were ignored. Now, any path containing
(disabled):is ignored as it represents a virtual file that doesn't exist on disk.Fixes #33160