feat(@schematics/angular): add refactor-fake-async migration#32784
Draft
yjaaidi wants to merge 2 commits intoangular:mainfrom
Draft
feat(@schematics/angular): add refactor-fake-async migration#32784yjaaidi wants to merge 2 commits intoangular:mainfrom
refactor-fake-async migration#32784yjaaidi wants to merge 2 commits intoangular:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new experimental schematic, refactor-fake-async, to migrate Angular's fakeAsync tests to use Vitest's fake timer APIs. The changes include the schematic implementation, transformers for fakeAsync, tick, and flush, and corresponding tests. Additionally, the findTestFiles utility function has been refactored into a shared location.
My review focuses on improving the robustness of the new transformers. I've suggested changes to ensure that the necessary vitest imports are always added when tick() or flush() are transformed, which will prevent potential issues with broken code after migration.
packages/schematics/angular/refactor/fake-async/transformers/tick.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is no migration from
fakeAsyncto Vitest fake timer APIs.Issue Number: N/A
What is the new behavior?
The current migration transforms the following test:
into:
Does this PR introduce a breaking change?
Open Questions
flushMicrotaskscan only be partially reproduced (i.e. explicitqueueMicrotaskcalls), transforming it have high chances of producing a broken test. Should we just skip transforming tests that use it?flushis used?flush'smaxTurnsoption?processNewMacroTasksSynchronouslyoption?flushandtickif used insidefakeAsyncbut it's probably better to just replace in the whole file as users might create some wrappers. What do you think?