Skip to content

fix(@angular/cli): use parsed package name for migrate-only updates#32782

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:update
Mar 17, 2026
Merged

fix(@angular/cli): use parsed package name for migrate-only updates#32782
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:update

Conversation

@alan-agius4
Copy link
Collaborator

This change updates the update command to use the parsed package name from npm-package-arg instead of the raw input string when performing a 'migrate-only' update. This ensures that package identifiers are correctly and consistently handled.

@alan-agius4 alan-agius4 changed the title fix(angular/cli): use parsed package name for migrate-only updates fix(@angular/cli): use parsed package name for migrate-only updates Mar 17, 2026
This change updates the update command to use the parsed package name from `npm-package-arg` instead of the raw input string when performing a 'migrate-only' update. This ensures that package identifiers are correctly and consistently handled.
@alan-agius4 alan-agius4 requested a review from clydin March 17, 2026 11:21
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Mar 17, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly updates the update command to use the parsed package name from npm-package-arg when performing a 'migrate-only' update. This ensures that the migrateOnly function receives the correct package identifier, improving the robustness and consistency of the update process. The previous implementation could have passed an unparsed package string or an undefined value, which is now resolved by using the name property from the npa.Result object.

@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 17, 2026
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 17, 2026
@alan-agius4 alan-agius4 merged commit c9f07db into angular:main Mar 17, 2026
39 checks passed
@alan-agius4 alan-agius4 deleted the update branch March 17, 2026 14:37
@alan-agius4
Copy link
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/cli target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants