build: update dependency https-proxy-agent to v8#32772
Open
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Open
build: update dependency https-proxy-agent to v8#32772alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Conversation
See associated pull request for more information. Closes angular#32762 as a pr takeover
alan-agius4
added
the
action: review
angular-robot
bot
added
the
area: build & ci
alan-agius4
added
the
target: minor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the https-proxy-agent dependency to version 8. The changes in inline-fonts.ts are necessary to accommodate the new ESM-only nature of the package. I've suggested improvements to avoid a type assertion and enhance type safety by importing the correct Agent type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See associated pull request for more information.
Closes #32762 as a pr takeover