fix(@angular/build): prioritize string type for runnerConfig schema#31847
Merged
dgp1130 merged 1 commit intoangular:mainfrom Nov 17, 2025
Merged
fix(@angular/build): prioritize string type for runnerConfig schema#31847dgp1130 merged 1 commit intoangular:mainfrom
dgp1130 merged 1 commit intoangular:mainfrom
Conversation
dgp1130
approved these changes
Nov 17, 2025
alan-agius4
approved these changes
Nov 17, 2025
Reorders the `type` union in the `runnerConfig` option's schema to prioritize `string` over `boolean`. This change provides a stronger hint to the CLI's argument parser, ensuring that when a value is provided for the option (e.g., a file path), it is unambiguously treated as a string. This improves the robustness of the parsing logic for this union-type option while preserving the functionality of its boolean flag forms.
clydin
force-pushed
the
unit-test/runner-config-path-cmd
branch
from
4da9400 to
fd316cf
Compare
Collaborator
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorders the
typeunion in therunnerConfigoption's schema to prioritizestringoverboolean.This change provides a stronger hint to the CLI's argument parser, ensuring that when a value is provided for the option (e.g., a file path), it is unambiguously treated as a string. This improves the robustness of the parsing logic for this union-type option while preserving the functionality of its boolean flag forms.