test: delete e2e directories after tests finish#31839
Merged
dgp1130 merged 3 commits intoangular:mainfrom Nov 19, 2025
Merged
Conversation
03398e7 to
d73758b
Compare
5232f3b to
f074f13
Compare
Deletes the e2e directories after tests complete to ensure a clean state for subsequent test runs and to free up disk space.
This reverts commit 7217478.
hybrist
approved these changes
Nov 17, 2025
Contributor
hybrist
left a comment
There was a problem hiding this comment.
Generally looks good but should we do this after the release on Wednesday, assuming that CI had been passing consistently with the larger machines? E.g. simpler mitigation while we prepare for the 21 release?
Collaborator
Author
|
SGTM @hybrist |
Ensures that the Verdaccio registry storage is properly cleaned up at the end of E2E tests by placing it within the main temporary directory which is now explicitly deleted on process exit or SIGINT. This change also centralizes the Verdaccio storage location, allowing both HTTP and HTTPS Verdaccio instances to share the same storage, simplifying test setup and cleanup. Removes redundant temporary directory creation logic for npm sandbox and temporary project roots, as these are now managed by a single `tmp-root`.
5101d2e to
23a3783
Compare
hybrist
approved these changes
Nov 19, 2025
Collaborator
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Deletes the e2e directories after tests complete to ensure a clean state for subsequent test runs and to free up disk space.