feat(@schematics/angular): add skipProvidedIn option to service schem…#31669
Closed
MeAkib wants to merge 1 commit intoangular:mainfrom
Closed
feat(@schematics/angular): add skipProvidedIn option to service schem…#31669MeAkib wants to merge 1 commit intoangular:mainfrom
MeAkib wants to merge 1 commit intoangular:mainfrom
Conversation
angular-robot
bot
added
detected: feature
…atic Add a new `skipProvidedIn` boolean option to the service schematic that allows developers to generate services without the `providedIn: 'root'` metadata in the @Injectable decorator. When set to true, the decorator will be rendered as `@Injectable()` instead of `@Injectable({ providedIn: 'root' })`. This provides flexibility for developers who prefer to manually provide services in specific modules or components rather than using the default tree-shakeable pattern. The option defaults to false to maintain backward compatibility and continue encouraging Angular's best practice of tree-shakeable services. fixes angular#31670
MeAkib
force-pushed
the
feat/clli-service-skip-providerIn
branch
from
e3378aa to
b1e9e7a
Compare
Collaborator
|
Closing as per #31670 (comment) |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…atic
Add a new
skipProvidedInboolean option to the service schematic that allows developers to generate services without theprovidedIn: 'root'metadata in the @Injectable decorator. When set to true, the decorator will be rendered as@Injectable()instead of@Injectable({ providedIn: 'root' }).This provides flexibility for developers who prefer to manually provide services in specific modules or components rather than using the default tree-shakeable pattern.
The option defaults to false to maintain backward compatibility and continue encouraging Angular's best practice of tree-shakeable services.
Fixes #31670
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #31670
What is the new behavior?
Does this PR introduce a breaking change?
Other information