This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Enable watching on nested ng-repeats.#177
Open
stereosteve wants to merge 1 commit intoangular-ui:masterfrom
stereosteve:nested_items
Open
Enable watching on nested ng-repeats.#177stereosteve wants to merge 1 commit intoangular-ui:masterfrom stereosteve:nested_items
stereosteve wants to merge 1 commit intoangular-ui:masterfrom
stereosteve:nested_items
Conversation
|
It seems to build failed with not related to the pull request error. Someone from @angular-ui can restart the build again. git commit --amend
git push -f origin nested_itemsI'd like this pull request, so I want to see this changes are merged sooner git commit --amend
git push -f origin nested_itemsI'd like this pull request, so I want to see it merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the case when you have two nested ng-repeats: an outer one for
optgroupand an inner repeat for theoptions.For example:
The current implementation only looks for
ng-repeaton an option element - in this case it causes a scoping issue, because cities is only defined inside of the parentng-repeat. As a result the initial value would not be set correctly.This change caused an error to sometimes be thrown on this line:
Removing it fixed the problem - all the tests pass and everything worked correctly, but I didn't figure out why.
I can add a test for nested
ng-repeatjust wanted to get some feedback first...