Additional notification code snippets migration#929
Open
alabiaga wants to merge 3 commits into
Open
Conversation
Change-Id: Ib7b51173d55bf49626fe9b19460e4d04d6994470
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive notification snippets, including channel creation, basic and styled notifications, tap actions, and reply handling with a dedicated ReplyReceiver. Feedback focuses on addressing a potential resource leak by properly closing an InputStream in ReplyReceiver, improving type safety when accessing the NotificationManager, and using shared constants for notification reply keys to ensure consistency.
Change-Id: Ia2c1c24f4c11b8273210a641485c90fb17985c54
Change-Id: If7261d0c60c902ba0a3b59043c3ce94d9c2c2390
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Ib7b51173d55bf49626fe9b19460e4d04d6994470
For documentation in: https://developer.android.com/develop/ui/compose/notifications/create-notification