Skip to content

Add network validate check and defaultNetwork callback #2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jaehwa-Noh wants to merge 4 commits into
base: main
Choose a base branch
from
+39 −8
Open

Add network validate check and defaultNetwork callback #2095

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8df69f6
Add validate check and defaultNetwork callback
Jaehwa-Noh Apr 12, 2026
26b0317
Apply suggestions from code review
Jaehwa-Noh Apr 12, 2026
e4c2528
Remove with
Jaehwa-Noh Apr 12, 2026
5cf78df
Merge remote-tracking branch 'origin/internet-connection' into intern…
Jaehwa-Noh Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 39 additions & 8 deletions .../com/google/samples/apps/nowinandroid/core/data/util/ConnectivityManagerNetworkMonitor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import android.net.Network
import android.net.NetworkCapabilities
import android.net.NetworkRequest
import android.net.NetworkRequest.Builder
import android.os.Build
import androidx.core.content.getSystemService
import androidx.tracing.trace
import com.google.samples.apps.nowinandroid.core.common.network.Dispatcher
Expand Down Expand Up @@ -58,21 +59,43 @@ internal class ConnectivityManagerNetworkMonitor @Inject constructor(
private val networks = mutableSetOf<Network>()

override fun onAvailable(network: Network) {
networks += network
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.N) {
networks += network
}
channel.trySend(true)
}

override fun onLost(network: Network) {
networks -= network
channel.trySend(networks.isNotEmpty())
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
channel.trySend(false)
} else {
networks -= network
channel.trySend(networks.isNotEmpty())
}
}

override fun onCapabilitiesChanged(
network: Network,
networkCapabilities: NetworkCapabilities,
) {
super.onCapabilitiesChanged(network, networkCapabilities)

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
val isNetworkConnected = networkCapabilities.isNetworkConnected()
channel.trySend(isNetworkConnected)
}
}
}

trace("NetworkMonitor.registerNetworkCallback") {
val request = Builder()
.addCapability(NetworkCapabilities.NET_CAPABILITY_INTERNET)
.build()
connectivityManager.registerNetworkCallback(request, callback)
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
connectivityManager.registerDefaultNetworkCallback(callback)
} else {
val request = Builder()
.addCapability(NetworkCapabilities.NET_CAPABILITY_INTERNET)
.build()
connectivityManager.registerNetworkCallback(request, callback)
}
}

/**
Expand All @@ -90,6 +113,14 @@ internal class ConnectivityManagerNetworkMonitor @Inject constructor(

private fun ConnectivityManager.isCurrentlyConnected(): Boolean {
val networkCapabilities = getNetworkCapabilities(activeNetwork) ?: return false
return networkCapabilities.hasCapability(NetworkCapabilities.NET_CAPABILITY_INTERNET)
return networkCapabilities.isNetworkConnected()
}

/**
* Check [NetworkCapabilities.NET_CAPABILITY_INTERNET]
* and [NetworkCapabilities.NET_CAPABILITY_VALIDATED]
*/
private fun NetworkCapabilities.isNetworkConnected(): Boolean =
hasCapability(NetworkCapabilities.NET_CAPABILITY_INTERNET) &&
hasCapability(NetworkCapabilities.NET_CAPABILITY_VALIDATED)
}
Loading