[Bug Fix]: Fixed text color updates on cards after light<>dark mode changes#1996
Open
shrikantbadwaik wants to merge 1 commit intoandroid:mainfrom
Open
[Bug Fix]: Fixed text color updates on cards after light<>dark mode changes#1996shrikantbadwaik wants to merge 1 commit intoandroid:mainfrom
shrikantbadwaik wants to merge 1 commit intoandroid:mainfrom
Conversation
Author
|
@dturner please review my pr |
shrikantbadwaik
force-pushed
the
shrikant/bug/text-color-changes
branch
from
3d87d56 to
91cdc39
Compare
Author
|
@dturner bumping this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I have done and why
Problem
When switching between light and dark themes in the Settings dialog, text colors on news cards (in "For You" and "Saved" tabs) were not updating immediately. Users had to scroll away and back for the colors to refresh.
Solution
Added a key() wrapper around the NewsResourceCardExpanded content that observes the theme's onSurface color
References
#1892
#1901
Before:
modechange.mp4
After:
fixed.mp4