Open
Conversation
Contributor
|
Better yet, don't expect States in you components. Expect the final value as a parameter |
Contributor
|
Every time you read state in a Composable, you're creating a subscription. That Composable will recompose whenever that state changes. Read state too early in your composition tree, and you might be triggering unnecessary recompositions across large portions of your UI. |
| internal fun SearchScreen( | ||
| modifier: Modifier = Modifier, | ||
| searchQuery: String = "", | ||
| searchQueryState: State<String> = remember { mutableStateOf("") }, |
Contributor
There was a problem hiding this comment.
bad practice for passing State objects as parameter
Deffer state in compose by lambda
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I have done and why
I refactored the SearchRoute → SearchScreen → SearchToolbar → SearchTextField chain to reduce unnecessary recompositions when the search query changes.
Before: entering a search query triggered recomposition of
SearchRoute, SearchScreen, SearchToolbar, SearchTextField, EmptySearchResultBody, RecentSearchesBody.
After: only SearchTextField and EmptySearchResultBody are recomposed.
SearchRoute, SearchScreen, and SearchToolbar stay stable.
This was achieved by:
The approach is similar to this recomposition visualization(before) and this one (after).
In the "before" example, intermediate functions get recomposed unnecessarily because they take a changing value as a parameter. In the "after" example, they take a stable lambda, so only the leaf node (RedBox) is recomposed.
Why:
I followed the official Compose best practice — “Defer reads as long as possible” (see Android Performance Best Practices) — by deferring access to changing data until it’s needed, thus avoiding unnecessary recompositions.