(feat) Add environments to repository model#204
Open
jpascoe wants to merge 1 commit intoanancarv:masterfrom
Open
(feat) Add environments to repository model#204jpascoe wants to merge 1 commit intoanancarv:masterfrom
jpascoe wants to merge 1 commit intoanancarv:masterfrom
Conversation
Author
|
I've created issue 205 |
anancarv
requested changes
Nov 23, 2024
| description: Optional[str] = None | ||
| url: str | ||
| packageType: str | ||
| environments: List[str] = ['DEV'] |
Owner
There was a problem hiding this comment.
No need to add the environment here. The Get repositories response does not contain environment (See Artifactory API)
Comment on lines
+24
to
+25
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", |
Owner
There was a problem hiding this comment.
If you want to add support to Python 3.13, you will need to add it to the test matrix here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I needed to be able to set the environments for a repository in our corporate JFrog Artifactory. This is a simple addition to the model.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How has it been tested ?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist: