Skip to content

Fix buffering overlay showing when stopping the player #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fethica merged 2 commits into from
Feb 4, 2026
Merged

Fix buffering overlay showing when stopping the player #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf30ad8
Add MarqueeLabel to open source libraries list
fethica Feb 4, 2026
229cd8c
Fix buffering overlay showing when stopping the player
fethica Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions SwiftRadio/Config/Config.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ struct Config {
LibraryItem(owner: "MengTo", repo: "Spring"),
LibraryItem(owner: "ninjaprox", repo: "NVActivityIndicatorView"),
LibraryItem(owner: "LeoNatan", repo: "LNPopupController"),
LibraryItem(owner: "cbpowell", repo: "MarqueeLabel"),
]
}

Expand Down
6 changes: 2 additions & 4 deletions SwiftRadio/ViewControllers/NowPlayingViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,15 +117,13 @@ class NowPlayingViewController: UIViewController {

func playerStateDidChange(_ state: FRadioPlayer.State) {
switch state {
case .loading:
case .loading where player.playbackState != .stopped:
albumArtworkView.setBuffering(true)
case .readyToPlay, .loadingFinished:
albumArtworkView.setBuffering(false)
playbackStateDidChange(player.playbackState)
case .error:
albumArtworkView.setBuffering(false)
default:
break
albumArtworkView.setBuffering(false)
}
}

Expand Down
6 changes: 2 additions & 4 deletions SwiftRadio/ViewControllers/StationsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,12 +284,10 @@ extension StationsViewController: FRadioPlayerObserver {

func radioPlayer(_ player: FRadioPlayer, playerStateDidChange state: FRadioPlayer.State) {
switch state {
case .loading:
case .loading where player.playbackState != .stopped:
isBuffering = true
case .readyToPlay, .loadingFinished, .error:
isBuffering = false
default:
break
isBuffering = false
}
updateNowPlayingAnimation()
updateVisibleCellsNowPlaying()
Expand Down