fix: allow 'expanded' attribute in Purifier#40501
Merged
erwinmombay merged 5 commits intoampproject:mainfrom Apr 9, 2026
Merged
fix: allow 'expanded' attribute in Purifier#40501erwinmombay merged 5 commits intoampproject:mainfrom
erwinmombay merged 5 commits intoampproject:mainfrom
Conversation
Allow 'expanded' to be preserved during HTML sanitization. This is needed for amp-accordion (and Bento accordion) when rendered inside templates like amp-mustache, where state attributes on standard tags (like <section>) were being stripped. Includes test case for standard elements.
Allow 'expanded' to be preserved during HTML sanitization. This is needed for amp-accordion (and Bento accordion) when rendered inside templates like amp-mustache, where state attributes on standard tags (like <section>) were being stripped. Includes test case for standard elements.
Member
Author
|
@danielrozenberg could you review this. thanks! |
danielrozenberg
approved these changes
Apr 7, 2026
Member
Author
|
need to do a manual test before merging |
Member
Author
|
verified the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow 'expanded' to be preserved during HTML sanitization. This is needed for amp-accordion