Skip to content

Add npm dev scripts and stabilize amp-nexxtv-player tests #40433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bahaeddinmselmi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add npm dev scripts and stabilize amp-nexxtv-player tests #40433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion extensions/amp-nexxtv-player/0.1/amp-nexxtv-player.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,9 @@ class AmpNexxtvPlayer extends AMP.BaseElement {
});
this.pauseHelper_.updatePlaying(true);

return this.loadPromise(this.iframe_);
if (!this.element.hasAttribute('data-origin')) {
return this.loadPromise(this.iframe_);
}
});
}

Expand Down
9 changes: 8 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,14 @@
},
"scripts": {
"preinstall": "node build-system/common/check-package-manager.js",
"postinstall": "node build-system/task-runner/install-amp-task-runner.js"
"postinstall": "node build-system/task-runner/install-amp-task-runner.js",
"serve": "node amp.js serve",
"build": "node amp.js build",
"dev": "node amp.js default",
"lint": "node amp.js lint --local_changes",
"lint:all": "node amp.js lint",
"lint:fix": "node amp.js lint --local_changes --fix",
"test": "node amp.js unit"
},
"dependencies": {
"@ampproject/animations": "0.2.2",
Expand Down