-
Notifications
You must be signed in to change notification settings - Fork 54
Refactor #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactor #22
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6813203
removed stakeFor function
aalavandhan 8c73361
updated interface
aalavandhan 3b91c11
made storage variables public
aalavandhan c94981f
using clonable token pool and safe transfer
aalavandhan 512e853
upgradable token geyser
aalavandhan d3b664b
added pausability
aalavandhan 9e7528b
added reentrant checks
aalavandhan b8e2cb8
typo
aalavandhan 03e4bec
renamed user totals to user
aalavandhan 0249dfa
renamed totalStakedFor to totalStakedBy
aalavandhan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| // SPDX-License-Identifier: GPL-3.0-or-later | ||
| pragma solidity ^0.8.24; | ||
|
|
||
| import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol"; | ||
|
|
||
| /** | ||
| * @title Geyser staking interface | ||
| */ | ||
| interface ITokenGeyser { | ||
| function stake(uint256 amount) external; | ||
| function unstake(uint256 amount) external returns (uint256); | ||
| function totalStakedBy(address addr) external view returns (uint256); | ||
| function totalStaked() external view returns (uint256); | ||
| function totalLocked() external view returns (uint256); | ||
| function totalUnlocked() external view returns (uint256); | ||
| function stakingToken() external view returns (IERC20); | ||
| function distributionToken() external view returns (IERC20); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // SPDX-License-Identifier: GPL-3.0-or-later | ||
| pragma solidity ^0.8.24; | ||
|
|
||
| import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol"; | ||
|
|
||
| /** | ||
| * @title Token pool interface | ||
| */ | ||
| interface ITokenPool { | ||
| function init(IERC20 token_) external; | ||
| function token() external view returns (IERC20); | ||
| function balance() external view returns (uint256); | ||
| function transfer(address to, uint256 value) external; | ||
| function rescueFunds(address tokenToRescue, address to, uint256 amount) external; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the name change, but flagging that it would mean changes for the frontend. Assuming it would need to be smart enough to know which contract version it's talking to on the backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. I think for the new frontend we shouldn't expect backward compatibility with OG v1