-
Notifications
You must be signed in to change notification settings - Fork 1
Jaspal packageplugin tech support changes #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alexandraBara
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add functional test, or update existing if there and also add utest for the new functions/functionality you have added.
| self.result.status = ExecutionStatus.OK | ||
| self._log_event( | ||
| category=EventCategory.OS, | ||
| description=f"Found {len(rocm_packages)} ROCm-related packages installed as per given regex: {rocm_pattern}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| description=f"Found {len(rocm_packages)} ROCm-related packages installed as per given regex: {rocm_pattern}", | |
| description=f"Found {len(rocm_packages)} ROCm-related packages installed.", |
Leave the regex out since it will be printed as part of the data
716fd1a to
868f1bb
Compare
Adding support in PackagePlugin to filter rocm packages with regex like:
'ocl-icd|kfdtest|llvm-amd|miopen|half|^ii hip|hcc|hsa|rocm|atmi|^ii comgr|composa|amd-smi|aomp|amdgpu|rock|mivision|migraph|rocprofiler|roctracer|rocbl|hipify|rocsol|rocthr|rocff|rocalu|rocprim|rocrand|rccl|rocspar|rdc|rocwmma|rpp|openmp|amdfwflash|ocl|opencl'Before:
After:
Test with the plugin_config.json:
Run:
node-scraper --plugin-config plugin_config.json