Skip to content

Conversation

@alexandraBara
Copy link
Collaborator

Fixing this issue:

| RocmPlugin    | ERROR            | Analysis error: ROCm version mismatch! Expected: ['7.0.0-38 '], actual: 7.0.0-38 |
|               |                  | (1 errors) 

and this confusing printout

| PackagePlugin | ERROR            | Analysis error: Package version missmatched. Missmatched versions: [('gcc',      |
|               |                  | None)], not found versions: [] (1 errors)  

Sample plugin config to run with, plugin_config.json:

{
  "global_args": {},
  "plugins": {
    "BiosPlugin": {
      "analysis_args": {
        "exp_bios_version": "3.5"
      }
    },
    "CmdlinePlugin": {
      "analysis_args": {
        "cmdline": "imgurl=test NODE=nodename selinux=0 serial console=ttyS1,115200 console=tty0",
        "required_cmdline" : "selinux=0"
      }
    },
    "DkmsPlugin": {
      "analysis_args": {
        "dkms_status": "amdgpu/6.11",
        "dkms_version" : "dkms-3.1",
        "regex_match" : true
      }
    },
    "KernelPlugin": {
      "analysis_args": {
        "exp_kernel": "5.11-generic"
      }
    },
    "OsPlugin": {
      "analysis_args": {
        "exp_os": "Ubuntu 22.04.2 LTS"
      }
    },
    "PackagePlugin": {
          "analysis_args": {
            "exp_package_ver": {
              "gcc": "11.4.0"
            },
            "regex_match": false
          }
    },
    "RocmPlugin": {
      "analysis_args": {
        "exp_rocm": "7.0.0-38 "
      }
    },
    "JournalPlugin": {
      "collection_args": {
        "boot": 2
      }
    }
  },
  "result_collators": {},
  "name": "plugin_config",
  "desc": "Auto generated config"
}

Cmd to run:

node-scraper --plugin-config ~/plugin_config.json

self.result.status = ExecutionStatus.OK
return self.result
elif data.bios_version == bios_version:
elif data.bios_version == str(bios_version).strip():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this and the other similar changes it will be better to add a validator onto the analyzer args pydantic model to perform this validation when the model is instantiated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

@alexandraBara alexandraBara merged commit ac42812 into development Nov 21, 2025
5 checks passed
@alexandraBara alexandraBara deleted the alex_fixes branch November 21, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants