Enabling to skip sudo plugins #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandraBara
changed the title
Collaborator
Author
|
@landrews-amd i have updated this PR and enabled to skip sudo through cmd line args as well since my team keeps running into issues like this and doing it through configs isnt enough. We run tests mostly without providing plugin configs |
Collaborator
Author
|
@cmcknigh we can update our tests to look like this: notice the extra --skip-sudo cmd line arg |
landrews-amd
requested changes
Aug 15, 2025
nodescraper/cli/cli.py
Outdated
Comment on lines
429
to
430
| for pcfg in plugin_config_inst_list: | ||
| pcfg.global_args.setdefault("collection_args", {})["skip_sudo"] = True |
Collaborator
There was a problem hiding this comment.
This would only need to be added to the last config in the list, not every one. They will be merged together in plugin executor, with the last config taking precedence.
Comment on lines
49
to
52
| if args.skip_sudo: | ||
| self.result.message = "Skipping sudo plugin" | ||
| self.result.status = ExecutionStatus.NOT_RAN | ||
| return self.result, None |
Collaborator
There was a problem hiding this comment.
This should only be done if targeting linux.
Comment on lines
49
to
52
| if args.skip_sudo: | ||
| self.result.message = "Skipping sudo plugin" | ||
| self.result.status = ExecutionStatus.NOT_RAN | ||
| return self.result, None |
Collaborator
There was a problem hiding this comment.
This should only be done when targeting linux
landrews-amd
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample runs:
plugin that require sudo can be skipped through setting global_args in plugin config:
Sample run: