Skip to content

Conversation

@alexandraBara
Copy link
Collaborator

Updating storage to also check for % free space.
Both abs and prct args are optional. If neither is provided, prct will default to 10% free.

 min_required_free_space_abs: Optional[str] = None
 min_required_free_space_prct: int = None

min_required_free_space_prct defaults to 10% in storage_analyzer

@hearnsj-amd
Copy link
Collaborator

Looks good to me. 10% free is a good value to warn at - for instance CEPH filesystems stop working at 5% free

@landrews-amd I do not fully understand "...supporting a None value for free space percentage would be good ... to continue to support the current behavior that is used internally."
No problem with a None value - just curious.

@alexandraBara
Copy link
Collaborator Author

Looks good to me. 10% free is a good value to warn at - for instance CEPH filesystems stop working at 5% free

@landrews-amd I do not fully understand "...supporting a None value for free space percentage would be good ... to continue to support the current behavior that is used internally." No problem with a None value - just curious.

At first we had hardcoded 10% to be the default prct, but we are now only setting it to 10% when the user doesnt specify abs or prct values. That way, if the user only wants to check an abs value and not care about prct - that still holds. This allows us to keep parity with the current behavior, which the internal tool has.

Copy link
Collaborator

@landrews-amd landrews-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandraBara alexandraBara merged commit 66d7d58 into development Jun 16, 2025
5 checks passed
@landrews-amd landrews-amd deleted the alex_storage branch June 26, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants