-
Notifications
You must be signed in to change notification settings - Fork 1
Storage plugin updates #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks good to me. 10% free is a good value to warn at - for instance CEPH filesystems stop working at 5% free @landrews-amd I do not fully understand "...supporting a None value for free space percentage would be good ... to continue to support the current behavior that is used internally." |
At first we had hardcoded 10% to be the default prct, but we are now only setting it to 10% when the user doesnt specify abs or prct values. That way, if the user only wants to check an abs value and not care about prct - that still holds. This allows us to keep parity with the current behavior, which the internal tool has. |
landrews-amd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updating storage to also check for % free space.
Both abs and prct args are optional. If neither is provided, prct will default to 10% free.
min_required_free_space_prct defaults to 10% in storage_analyzer