Change form_with extension's default :model option#34
Open
seanpdoyle wants to merge 1 commit intoamatsuda:masterfrom
Open
Change form_with extension's default :model option#34seanpdoyle wants to merge 1 commit intoamatsuda:masterfrom
form_with extension's default :model option#34seanpdoyle wants to merge 1 commit intoamatsuda:masterfrom
Conversation
As of `rails@~>7.2.0`, the `form_with` method [rejects][] `:model` options that are `nil`. To achieve compatibility with the new support, this commit modifies the form builder extension to change the default `:model` keyword argument to `model: false` rather than `model: nil`. To exercise that behavior, this commit introduces the `FormsController` to the test suite, along with `#new` and `#create` routes. [rejects]: rails/rails@12b093d
Author
|
@amatsuda I'd opened this PR without knowledge of #33. The changes in this diff aim to resolve the same issue, but with fewer changes. For example, it does not modify the CI matrix, and does not duplicate the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32
As of
rails@~>7.2.0, theform_withmethod rejects:modeloptions that arenil. To achieve compatibility with the new support, this commit modifies the form builder extension to change the default:modelkeyword argument tomodel: falserather thanmodel: nil.To exercise that behavior, this commit introduces the
FormsControllerto the test suite, along with#newand#createroutes.