feat: implement IDR Rate Aggregator service using Frankfurter API#176
Open
hosea-adrianus wants to merge 6 commits intoallobankdev:mainfrom
Open
feat: implement IDR Rate Aggregator service using Frankfurter API#176hosea-adrianus wants to merge 6 commits intoallobankdev:mainfrom
hosea-adrianus wants to merge 6 commits intoallobankdev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the IDR Rate Aggregator Service, responsible for fetching and preloading exchange rate data from Frankfurter API which consist of 3 API Endpoint:
GET /api/finance/data/latest_idr_ratesGET /api/finance/data/historical_idr_usdGET /api/finance/data/supported_currenciesKey features:
Architectural Rationale
i. Polymorphism Justification
The Strategy Pattern is used to handle the multi-resource endpoint so that each resource type (historical, latest, currencies) has its own implementation, avoiding bulky if-else or switch statements in the service layer.
Benefits:
IDRDataFetcher, without changing the service.ii. Client Factory
A FactoryBean is used to construct the FrankfurterWebClient with dynamic configurations like baseUrl and ObjectMapper strategy.
Advantages over a simple @bean:
iii. Startup Runner Choice
ApplicationRunner is chosen to preload data at application startup because: