Open
Conversation
Fluf22
reviewed
Feb 18, 2026
packages/cache-browser-local-storage/src/createBrowserLocalStorageCache.ts
Show resolved
Hide resolved
Fluf22
reviewed
Feb 18, 2026
packages/cache-browser-local-storage/src/createBrowserLocalStorageCache.ts
Outdated
Show resolved
Hide resolved
Haroenv
reviewed
Feb 19, 2026
Contributor
Haroenv
left a comment
Haroenv
left a comment
There was a problem hiding this comment.
I doubt this is the only inefficient promise-related code, but if it works for your use case, lgtm. I personally would add tests and compare with v5 though
|
|
||
| function yieldToMain(): Promise<void> { | ||
| // eslint-disable-next-line no-undef | ||
| const g: any = typeof globalThis !== 'undefined' ? globalThis : undefined; |
Contributor
There was a problem hiding this comment.
why do you cast this as any and not Window or something? seems a bit odd to lie to typescript
| if (g && g.scheduler && g.scheduler.yield) { | ||
| return g.scheduler.yield().catch((error: any) => { | ||
| // eslint-disable-next-line no-console | ||
| console.error('Failed to yield to main: ', error); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces localStorage blocking in
createBrowserLocalStorageCacheto improve INP by merging two filter passes into one (cuttingget()from 2 reads + 2 writes to 1 read + 1 write) and yielding to the main thread viascheduler.yield()/setTimeoutbefore heavy work inget(),set(), anddelete().