Skip to content

fix(java): ensure waitTask exception propagation #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eric-zaharia wants to merge 1 commit into
base: v3
Choose a base branch
from
Draft

fix(java): ensure waitTask exception propagation #799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions algoliasearch-core/src/main/java/com/algolia/search/TaskUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import com.algolia.search.exceptions.AlgoliaApiException;
import com.algolia.search.exceptions.AlgoliaRetryException;
import com.algolia.search.exceptions.AlgoliaRuntimeException;
import com.algolia.search.exceptions.LaunderThrowable;
import com.algolia.search.models.RequestOptions;
import com.algolia.search.models.common.TaskStatusResponse;
import java.util.Objects;
Expand Down Expand Up @@ -38,11 +39,13 @@ static void waitTask(

try {
response = getTaskAsync.apply(taskId, requestOptions).get();
} catch (InterruptedException | ExecutionException e) {
// If the future was cancelled or the thread was interrupted or future completed
// exceptionally
// We stop
break;
} catch (InterruptedException e) {
// Restore the interrupted status and surface the failure
Thread.currentThread().interrupt();
throw new AlgoliaRuntimeException(e);
} catch (ExecutionException e) {
// Surface the underlying error
throw LaunderThrowable.launder(e);
}

if (Objects.equals("published", response.getStatus())) return;
Expand Down