Implement custom node-based Conversions#198
Open
Greebling wants to merge 18 commits intoalelievr:masterfrom
Open
Implement custom node-based Conversions#198Greebling wants to merge 18 commits intoalelievr:masterfrom
Greebling wants to merge 18 commits intoalelievr:masterfrom
Conversation
This reverts commit a511e4a.
Author
|
Here an example of how this feature works inside the graph editor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented custom converter nodes with this branch. These nodes are automatically added when a user connects two ports that are convertible through by a node. I created the FloatToStringsNode to give an example of how this feature can be used. To test it out try to connect a 'Sub' node to the log input of the 'Console Log' node. You will see that the FloatToStringsNode is added inbetween to do the conversion from float to int automatically. This feature can be very useful in some cases, since some conversions rely on additional info given by the user, as shown by my example node.
Conversions now do not need to be symmetrical, as I reordered some parameters in the conversion checking to always be the right way around. This should fix what issue #173 talked about.
Additionally, some small fixes are implemented, mostly regarding nullreference exceptions. Also some small typos in the README. Some error messages were also made much clearer.
Sorry for bundling this all together into one large pull request. I dont use git a lot so this was the easiest way for me.