Correct labels container position to end of row#245
Open
kroeschl wants to merge 2 commits intoalejandro5042:masterfrom
Open
Correct labels container position to end of row#245kroeschl wants to merge 2 commits intoalejandro5042:masterfrom
kroeschl wants to merge 2 commits intoalejandro5042:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Justification
On the PR dashboard, I noticed that the PR labels are rendered in different locations on different PRs. This looks like an error in the way we're creating the pill container if it's not already present.
Implementation
Add the pills container before the end of the containing element instead of as a sibling after the PR title. Bump the version and update the change notification.
Testing
Testing in my browser, I now see the label pills always rendered after the title. I also sanity-checked the update notification.
