Update docs agent self-approval guard#1333
Merged
Merged
Conversation
Run the guard on PR updates and count historical non-requester approvals so pushes after review do not leave the required check stuck. Co-authored-by: Cursor <cursoragent@cursor.com>
🔗 Preview Mode
|
dslovinsky
approved these changes
May 26, 2026
Keep the self-approval guard focused on PR creation and pushes while review submissions continue to handle approval dismissal. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pnpm exec prettier --check .github/workflows/no-originator-self-approval.ymlnode --input-type=module -e "import fs from 'node:fs'; import yaml from 'js-yaml'; const doc = yaml.load(fs.readFileSync('.github/workflows/no-originator-self-approval.yml','utf8')); if (!doc.on?.pull_request || !doc.on?.pull_request_review) throw new Error('missing expected triggers'); console.log(JSON.stringify(doc.on));"pnpm dlx github-actionlint .github/workflows/no-originator-self-approval.ymlalchemyplatform/docs#1321; it finds prior non-requester approvals.Made with Cursor