docs: 添加 OVN Underlay 首包延迟优化文档(S2 跳过 Conntrack 方案)#134
docs: 添加 OVN Underlay 首包延迟优化文档(S2 跳过 Conntrack 方案)#134changluyi wants to merge 4 commits intoalauda:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
WalkthroughA new English and Chinese solution doc were added explaining how to configure Kube-OVN's Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
docs/zh/solutions/How_to_Optimize_OVN_Underlay_First_Packet_Latency_with_Skip_Conntrack.md (1)
36-36: 中文文档标题建议保持全中文术语。Line 36 的
### Step 1建议改为### 步骤 1,与中文文档整体风格一致。🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/zh/solutions/How_to_Optimize_OVN_Underlay_First_Packet_Latency_with_Skip_Conntrack.md` at line 36, 将标题中的英文“Step”替换为中文“步骤”以保持文档术语一致:把当前标题文本 `### Step 1: 配置 Kube-OVN Controller` 修改为 `### 步骤 1: 配置 Kube-OVN Controller`(定位文本可通过该标题字符串本身查找并替换)。
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@docs/zh/solutions/How_to_Optimize_OVN_Underlay_First_Packet_Latency_with_Skip_Conntrack.md`:
- Line 12: The Chinese doc mentions reducing "conntrack 表压力" as a benefit but
the English version doesn't; update for consistency by either adding the same
benefit to the English paragraph describing skip-conntrack-dst-cidrs or remove
the "conntrack 表压力" phrase from the Chinese paragraph so both languages describe
the same benefits; locate the description of skip-conntrack-dst-cidrs in this
document and make the change accordingly.
- Around line 46-50: The YAML snippet only shows args and may be applied to the
wrong container in multi-container Pods; update the doc to include the
surrounding context matching the English version by adding the containers: block
and the specific container identifier name: kube-ovn-controller so the
--skip-conntrack-dst-cidrs argument is clearly under containers -> - name:
kube-ovn-controller -> args, and ensure you do not alter other container
parameters or indentation so only that container receives the flag.
---
Nitpick comments:
In
`@docs/zh/solutions/How_to_Optimize_OVN_Underlay_First_Packet_Latency_with_Skip_Conntrack.md`:
- Line 36: 将标题中的英文“Step”替换为中文“步骤”以保持文档术语一致:把当前标题文本 `### Step 1: 配置 Kube-OVN
Controller` 修改为 `### 步骤 1: 配置 Kube-OVN Controller`(定位文本可通过该标题字符串本身查找并替换)。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2254a0eb-e6a7-40a1-ac20-58d67691b36b
📒 Files selected for processing (2)
docs/en/solutions/How_to_Optimize_OVN_Underlay_First_Packet_Latency_with_Skip_Conntrack.mddocs/zh/solutions/How_to_Optimize_OVN_Underlay_First_Packet_Latency_with_Skip_Conntrack.md
docs/zh/solutions/How_to_Optimize_OVN_Underlay_First_Packet_Latency_with_Skip_Conntrack.md
Outdated
Show resolved
Hide resolved
docs/zh/solutions/How_to_Optimize_OVN_Underlay_First_Packet_Latency_with_Skip_Conntrack.md
Show resolved
Hide resolved
- 删除中文版残留的 conntrack 表压力描述 - 补全 YAML 片段中 containers/name 定位信息
Head branch was pushed to by a user without write access
|
|
||
| > **警告**:一旦对某个目标 CIDR 跳过 conntrack,以下 OVN 功能对该 CIDR 的流量将**不再生效**: | ||
| > - **NetworkPolicy** — 依赖 conntrack 状态的 OVN ACL 规则将无法匹配 | ||
| > - **Service 负载均衡** — ClusterIP/NodePort 服务的 OVN LB 规则将被绕过 |
There was a problem hiding this comment.
这个和 UI 上保持一致说法, 内部路由
后面改为说明现象,比如配置了 Network policy 也无法控制 pod 流量,以及无法通过 cluster Ip 或者 node port 访问 service
Summary
skip-conntrack-dst-cidrs参数的配置方法和使用注意事项Test plan
Summary by CodeRabbit