enhancement/Add Tests + Fix State Management Issues (for web mainly) + Small Refactors#296
Closed
Dario-Maselli wants to merge 17 commits into
Closed
enhancement/Add Tests + Fix State Management Issues (for web mainly) + Small Refactors#296Dario-Maselli wants to merge 17 commits into
Dario-Maselli wants to merge 17 commits into
Conversation
This reverts commit 86a8d84.
Contributor
Author
|
I do plan on adding Golden Tests soon 👀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
It seems like a lot of changes... but it really is not. I've added more tests for the analyzer code and did a little bit of bug fixing/enhancement for the state management, specifically on Web as sometimes the context (technically state) has not been created yet.
Added tests?
Added to documentation?