Skip to content

Fix: Buffer.from() in CRC helpers prevents browser/Deno/Bun execution #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinelliott wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Buffer.from() in CRC helpers prevents browser/Deno/Bun execution #444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lib/utils/arinc_702_helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,15 @@ import { FlightPlanUtils } from './flight_plan_utils';
import { ResultFormatter } from './result_formatter';
import { RouteUtils } from './route_utils';

// One byte per ASCII char — replaces the Buffer.from(data, 'ascii') idiom so
// the CRC helpers run in browser / Deno / Bun / edge runtimes without Node
// polyfills. Matches the broader Web APIs migration in c78b720.
function asciiStringToBytes(data: string): Uint8Array {
const bytes = new Uint8Array(data.length);
for (let i = 0; i < data.length; i++) bytes[i] = data.charCodeAt(i) & 0xff;
return bytes;
}

/**
* Helper class for decoding ARINC 702 messages
* contains core logic for decoding different types of ARINC 702 messages,
Expand Down Expand Up @@ -658,7 +667,7 @@ function processSummary(decodeResult: DecodeResult, data: string[]) {
// CRC-16/IBM-SDLC but nibbles are reversed
function crc16IbmSdlcRev(data: string): number {
let crc = 0xffff;
const bytes = Buffer.from(data, 'ascii');
const bytes = asciiStringToBytes(data);

for (const byte of bytes) {
crc ^= byte;
Expand Down Expand Up @@ -689,7 +698,7 @@ function crc16Genibus(data: string): number {
let crc = 0xffff;
const polynomial = 0x1021;

const bytes = Buffer.from(data, 'ascii');
const bytes = asciiStringToBytes(data);

for (const byte of bytes) {
crc ^= byte << 8;
Expand Down
Loading