Skip to content

Normalize FUEL_REM code and stringify sequence formatter values #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Normalize FUEL_REM code and stringify sequence formatter values #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87172bc
Initial plan
Copilot May 28, 2026
00e1bb8
Fix formatter FUEL_REM code and sequence value string formatting
Copilot May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/plugins/Label_44_OFF.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ describe('Label 44 OFF', () => {
);
expect(decodeResult.formatted.items[6].value).toBe('02:48:00');
expect(decodeResult.formatted.items[7].label).toBe('Fuel Remaining');
expect(decodeResult.formatted.items[7].code).toBe('FUEL_REM');
expect(decodeResult.formatted.items[7].value).toBe('11.1');
});

Expand Down
10 changes: 10 additions & 0 deletions lib/plugins/Label_H1_INI.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ describe('Label_H1 INI', () => {
expect(decodeResult.remaining.text).toBe('');
expect(decodeResult.formatted.items.length).toBe(9);
expect(decodeResult.formatted.description).toBe('Initial Report');
const sequenceNumberItem = decodeResult.formatted.items.find(
(item) => item.code === 'SEQ',
);
const sequenceResponseItem = decodeResult.formatted.items.find(
(item) => item.code === 'SEQ_RESP',
);
expect(sequenceNumberItem).toBeDefined();
expect(sequenceNumberItem?.value).toBe('2');
expect(sequenceResponseItem).toBeDefined();
expect(sequenceResponseItem?.value).toBe('0');
});

test('#MD valid', () => {
Expand Down
6 changes: 3 additions & 3 deletions lib/utils/result_formatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ export class ResultFormatter {
decodeResult.raw.fuel_remaining = value;
decodeResult.formatted.items.push({
type: 'fuel_remaining',
code: ' FUEL_REM',
code: 'FUEL_REM',
label: 'Fuel Remaining',
value: decodeResult.raw.fuel_remaining.toString(),
});
Expand Down Expand Up @@ -665,7 +665,7 @@ export class ResultFormatter {
type: 'sequence',
code: 'SEQ',
label: 'Sequence Number',
value: decodeResult.raw.sequence_number,
value: decodeResult.raw.sequence_number.toString(),
});
}

Expand All @@ -675,7 +675,7 @@ export class ResultFormatter {
type: 'sequence',
code: 'SEQ_RESP',
label: 'Sequence Response',
value: decodeResult.raw.sequence_response,
value: decodeResult.raw.sequence_response.toString(),
});
}

Expand Down