-
Notifications
You must be signed in to change notification settings - Fork 40
feat: Add block_simultaneous_read with top-level stream_groups interface #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Anatolii Yatsuk (tolik0)
wants to merge
26
commits into
main
Choose a base branch
from
tolik0/concurrent-source/add-block_simultaneous_read
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,566
−18
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
e8697e0
Add block_simultaneous_read to DefaultStream
tolik0 1b4a9f0
Change `block_simultaneous_read` to string
tolik0 ec8dd6f
Fix StreamFacade
tolik0 450d7cf
Fix NoneType error when all streams are blocked
tolik0 3e7de2f
Fix unit tests
tolik0 b7fa9a5
Auto-fix lint and format issues
314ded1
Add retry deferred streams on stream completion
tolik0 80d8b2b
Fix unit tests
tolik0 8c06ce6
More fixes for unit tests
tolik0 49b0174
refactor: replace per-stream block_simultaneous_read with top-level s…
devin-ai-integration[bot] 219f7df
refactor: move stream_name_to_group into ModelToComponentFactory
devin-ai-integration[bot] 0390f4e
refactor: use stream_groups manifest in factory test instead of hardc…
devin-ai-integration[bot] cd55bfd
fix: only include parent stream in stream_groups to avoid deadlock
devin-ai-integration[bot] 5066ec7
style: fix ruff format for long line
devin-ai-integration[bot] 61562c4
refactor: move _build_stream_name_to_group into ModelToComponentFactory
devin-ai-integration[bot] ed82738
refactor: resolve stream_groups from actual stream instances instead …
devin-ai-integration[bot] 7ba206f
Fix stream format in schema
tolik0 d09ee9b
refactor: add get_partition_router() helper to DefaultStream
devin-ai-integration[bot] 94c4b82
feat: validate no parent-child streams share a group to prevent deadlock
devin-ai-integration[bot] 0874f12
feat: assert partition generation queue is empty when all streams are…
devin-ai-integration[bot] c868fdb
refactor: move inline imports to module level in default_stream.py an…
devin-ai-integration[bot] 1fffc69
fix: unwrap GroupingPartitionRouter in get_partition_router() to dete…
devin-ai-integration[bot] 5911051
fix: handle GroupingPartitionRouter at call sites instead of in get_p…
devin-ai-integration[bot] d01ee31
feat: check active_groups is empty in is_done() safety check
devin-ai-integration[bot] 9029049
test: add missing unit tests for GroupingPartitionRouter, active_grou…
devin-ai-integration[bot] 756a966
fix: make deadlock validation check all ancestors, not just direct pa…
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
232 changes: 218 additions & 14 deletions
232
airbyte_cdk/sources/concurrent_source/concurrent_read_processor.py
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.