Skip to content

Avoid error in src_reload if relative path cannot be resolved. Fixes #731 #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frmdstryr wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid error in src_reload if relative path cannot be resolved. Fixes #731 #732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c26f82
Avoid error in src_reload if relative path cannot be resolved. Fixes …
frmdstryr Nov 18, 2025
ff28691
Add test for error resolving relative path
frmdstryr Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion aiohttp_devtools/runserver/serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,11 @@ async def src_reload(app: web.Application, path: Optional[str] = None) -> int:

is_html = None
if path:
path = str(Path(app[STATIC_URL]) / Path(path).relative_to(app[STATIC_PATH]))
try:
path = str(Path(app[STATIC_URL]) / Path(path).relative_to(app[STATIC_PATH]))
except ValueError as e:
aux_logger.warning('error resolving relative path: %s', e)
return 0
is_html = mimetypes.guess_type(path)[0] == 'text/html'

reloads = 0
Expand Down
12 changes: 12 additions & 0 deletions tests/test_runserver_serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,18 @@ async def test_aux_reload_html_different():
assert ws.send_str.call_count == 0


async def test_aux_reload_no_static_path():
aux_app = Application()
ws = MagicMock()
ws.send_str = MagicMock(return_value=create_future())
aux_app[LAST_RELOAD] = [0, 0.]
aux_app[STATIC_PATH] = "."
aux_app[STATIC_URL] = "/static/"
aux_app[WS] = set(((ws, "/foo/bar"),)) # type: ignore[misc]
assert 0 == await src_reload(aux_app, '/path/to/static_files/foo/.bar.html.kate-swp')
assert ws.send_str.call_count == 0


async def test_aux_reload_runtime_error(smart_caplog):
aux_app = Application()
ws = MagicMock()
Expand Down