Skip to content

Add support for the bool data type for numpy>=2.0#71

Merged
agoscinski merged 1 commit intoaiidateam:mainfrom
agoscinski:numpy2.0-bool
Mar 1, 2026
Merged

Add support for the bool data type for numpy>=2.0#71
agoscinski merged 1 commit intoaiidateam:mainfrom
agoscinski:numpy2.0-bool

Conversation

@agoscinski
Copy link
Contributor

@agoscinski agoscinski commented Mar 1, 2026

The fix adds numpy.bool to cover numpy>=2.0 data types.

This was raised when testing aiida-core v2.8.0 #70 because numpy-2.2.6 was used. I assume this is because the changed dependency resolvement.

It's hard to test this properly without updating the whole CI infra. I feel like in the future it would make sense to test for numpy<2.0 and numpy>=2.0 in the CI and the whole numpy type system. There are other types also missing. Would just not put priority on this now.

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.82%. Comparing base (4f0b986) to head (16a3dfb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   89.82%   89.82%           
=======================================
  Files          22       22           
  Lines        1317     1317           
=======================================
  Hits         1183     1183           
  Misses        134      134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The fix adds `numpy.bool` to cover numpy>=2.0 data types.
@agoscinski agoscinski merged commit 4df7350 into aiidateam:main Mar 1, 2026
6 checks passed
@agoscinski agoscinski deleted the numpy2.0-bool branch March 1, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants